Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44077: Expose IP_RECVTOS in the socket module #25992

Merged
merged 4 commits into from Jun 20, 2021
Merged

bpo-44077: Expose IP_RECVTOS in the socket module #25992

merged 4 commits into from Jun 20, 2021

Conversation

@gsauthof
Copy link
Contributor

@gsauthof gsauthof commented May 8, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44077

https://bugs.python.org/issue44077
@the-knights-who-say-ni

This comment has been hidden.

Sign in to view
corona10
corona10 requested changes May 13, 2021
View changes
Copy link
Member

@corona10 corona10 left a comment

Please update Docs and NEWS

For your help: https://github.com/python/cpython/pull/24946/files and https://docs.python.org/3/library/socket.html?highlight=socket#socket.SOMAXCONN

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 13, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gsauthof
Copy link
Contributor Author

@gsauthof gsauthof commented May 13, 2021

I have made the requested changes; please review again.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 13, 2021

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 May 13, 2021
@corona10 corona10 self-assigned this May 14, 2021
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented May 14, 2021 •
edited

EDITED after updating my repository and discovering new 3.11.rst.
@pablogsal Pablo, are you willing for this new constant to be backported to 3.10.0b2 ?

Georg, unless Pablo says yes, the 'new in' entry should say 3.11 and the what's new entry moved to 3.11.rst.

@corona10 Is this something you might merge, or do we need to find a socket person (I am not)?

@corona10
Copy link
Member

@corona10 corona10 commented May 15, 2021

@terryjreedy
I think that if this PR is merged, this changed only affects 3.11

@corona10
Copy link
Member

@corona10 corona10 commented May 15, 2021

Is this something you might merge, or do we need to find a socket person

I often observe that this kind of constants adding was accepted.
But getting opinions from socket experts looks great.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 15, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10 corona10 removed their assignment May 15, 2021
@corona10
Copy link
Member

@corona10 corona10 commented May 15, 2021

@terryjreedy
FYI, I did not decide to merge this PR or not. Before accepting this PR we should investigate the use cases of IP_RECVTOS.
And if the socket expert exists, we can get a review from the expert.

@gsauthof
Copy link
Contributor Author

@gsauthof gsauthof commented May 15, 2021

I have made the requested changes; please review again.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 15, 2021

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 May 15, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Jun 15, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 15, 2021
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 20, 2021

@pablogsal Pablo, are you willing for this new constant to be backported to 3.10.0b2 ?

Sorry for the late response, This has flown under my radar :(

I am ok including this constant, as it is contained enough

@python python deleted a comment from corona10 Jun 20, 2021
@pablogsal pablogsal merged commit a317778 into python:main Jun 20, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 20, 2021

Thanks @gsauthof for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jun 20, 2021
@gsauthof @miss-islington
bpo-44077: Expose IP_RECVTOS in the socket module (pythonGH-25992)
ecd42ea 
Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a317778)

Co-authored-by: Georg Sauthoff <mail@georg.so>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 20, 2021

GH-26815 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jun 20, 2021
@gsauthof @miss-islington
bpo-44077: Expose IP_RECVTOS in the socket module (GH-25992)
28fe015 
Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
(cherry picked from commit a317778)

Co-authored-by: Georg Sauthoff <mail@georg.so>
@ShaneHarvey ShaneHarvey mentioned this pull request Jul 14, 2021
Merged
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@gsauthof @pablogsal @JuniorJPDJ
bpo-44077: Expose IP_RECVTOS in the socket module (pythonGH-25992)
2d020e5 
Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
CLA signed stale
Projects
None yet
Milestone
No milestone
7 participants
@gsauthof @the-knights-who-say-ni @bedevere-bot @terryjreedy @corona10 @pablogsal @miss-islington