Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved PX defaults #2957

Merged
merged 1 commit into from Dec 7, 2020
Merged

improved PX defaults #2957

merged 1 commit into from Dec 7, 2020

Conversation

nicolaskruchten
Copy link
Member

@nicolaskruchten nicolaskruchten commented Dec 6, 2020

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@nicolaskruchten nicolaskruchten requested a review from emmanuelle Dec 6, 2020
@nicolaskruchten
Copy link
Member Author

@nicolaskruchten nicolaskruchten commented Dec 6, 2020

@emmanuelle last-minute enhancement, should be fairly safe as it slightly expands some existing machinery, and adds some tests

@nicolaskruchten
Copy link
Member Author

@nicolaskruchten nicolaskruchten commented Dec 6, 2020

PS: the labels portion will even apply to imshow() by default.

@nicolaskruchten nicolaskruchten merged commit 1400241 into master Dec 7, 2020
16 checks passed
@archmoj archmoj deleted the pxdefaults2 branch Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
1 participant
@nicolaskruchten