Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full stop from bytes syntaxerror message #24300

Merged
merged 1 commit into from Jan 23, 2021
Merged

Remove full stop from bytes syntaxerror message #24300

merged 1 commit into from Jan 23, 2021

Conversation

numbermaniac
Copy link
Contributor

@numbermaniac numbermaniac commented Jan 23, 2021

Every other error I've seen raised by Python doesn't have a full stop at the end. This one appears to be an anomaly, so this PR removes the full stop to make it consistent with other errors.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jan 23, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@numbermaniac

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@numbermaniac
Copy link
Contributor Author

numbermaniac commented Jan 23, 2021

The "requested review" was automatic, I didn't do it myself. I hope I haven't accidentally bothered anyone unnecessarily with that!

@pablogsal
Copy link
Member

pablogsal commented Jan 23, 2021

Thanks for the catch @numbermaniac !

@pablogsal pablogsal merged commit bf9239b into python:master Jan 23, 2021
3 checks passed
@numbermaniac numbermaniac deleted the patch-1 branch Jan 24, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@numbermaniac @adorilson
Remove full stop from a bytes-related SyntaxError message (pythonGH-2…
f063d48 
…4300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numbermaniac @the-knights-who-say-ni @pablogsal @bedevere-bot