Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119461: Fix ThreadedVSOCKSocketStreamTest #119465

Merged
merged 1 commit into from
May 23, 2024
Merged

gh-119461: Fix ThreadedVSOCKSocketStreamTest #119465

merged 1 commit into from
May 23, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 23, 2024 •
edited
Loading

Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host address or the "any" address, use the local communication address (loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but get_cid() returns VMADDR_CID_ANY (-1).

@bedevere-app bedevere-app bot mentioned this pull request May 23, 2024
Closed
@vstinner
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest
d81cb0b 
Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).
@vstinner vstinner mentioned this pull request May 23, 2024
Closed
@vstinner vstinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 23, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit d81cb0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 23, 2024
@vstinner
Copy link
Member Author

buildbot/AMD64 Arch Linux TraceRefs PR: test failure looks unrelated:

test_basic_multiple_interpreters_reset_each (test.test_import.SinglephaseInitTests.test_basic_multiple_interpreters_reset_each) ... python: Objects/object.c:195: _PyRefchain_Remove: Assertion `value == REFCHAIN_VALUE' failed.
Fatal Python error: Aborted

Current thread 0x00007f3c8619e740 (most recent call first):
  File "<string>", line 54 in <module>

Extension modules: _testinternalcapi, _testmultiphase, _testcapi (total: 3)

buildbot/AMD64 Arch Linux Usan PR: build failure is unrelated.

Objects/object.c:1019:16: runtime error: call to function long_hash through pointer to incorrect function type 'long (*)(struct _object *)'

buildbot/ARM64 Windows Non-Debug PR: test_cext failure is unrelated.

  extension.c(50): warning C4116: unnamed type definition in parentheses
  extension.c(50): error C2059: syntax error: 'static_assert'
  extension.c(50): error C2059: syntax error: ')'
  extension.c(50): error C2059: syntax error: ','
  extension.c(52): error C2059: syntax error: 'return'
  extension.c(53): error C2059: syntax error: '}'
  extension.c(69): error C2065: '_testcext_slots': undeclared identifier
  extension.c(63): warning C4047: 'initializing': 'PyModuleDef_Slot *' differs in levels of indirection from 'int'
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.31.31103\\bin\\HostX86\\ARM64\\cl.exe' failed with exit code 2
  [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for internal-test-c11-cext

@vstinner vstinner merged commit e94dbe4 into python:main May 23, 2024
106 of 112 checks passed
@vstinner vstinner deleted the vsock_local branch May 23, 2024 21:26
vstinner added a commit to vstinner/cpython that referenced this pull request May 23, 2024
@vstinner
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)
8241456 
Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
@bedevere-app
Copy link

bedevere-app bot commented May 23, 2024

GH-119479 is a backport of this pull request to the 3.13 branch.

vstinner added a commit that referenced this pull request May 23, 2024
@vstinner
[3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (#119465) (#119479)
c750061 
gh-119461: Fix ThreadedVSOCKSocketStreamTest (#119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@vstinner @miss-islington
[3.13] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-1…
4bca8a5 
…19465) (pythonGH-119479)

pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)
@miss-islington miss-islington mentioned this pull request May 23, 2024
Merged
vstinner added a commit that referenced this pull request May 23, 2024
@miss-islington @vstinner
[3.12] [3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465) (
122dd4f 
GH-119479) (#119484)

[3.13] gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465) (GH-119479)

gh-119461: Fix ThreadedVSOCKSocketStreamTest (GH-119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)
6f31337 
Add socket.VMADDR_CID_LOCAL constant.

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
79fecc6 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
e5fb458 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hrnciar
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
cc2b987 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
hroncok pushed a commit to fedora-python/cpython that referenced this pull request Sep 11, 2024
@miss-islington @vstinner @hroncok
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
a3345bd 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
711d800 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
c90b131 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
frenzymadness pushed a commit to fedora-python/cpython that referenced this pull request Dec 3, 2024
@miss-islington @vstinner @frenzymadness
00438: Fix ThreadedVSOCKSocketStreamTest (pythonGH-119465) (pythonGH-…
fb0aa8b 
…119479) (python#119484)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit c750061)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit e94dbe4)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner mentioned this pull request Jan 22, 2025
Open
vstinner added a commit to vstinner/cpython that referenced this pull request Jan 22, 2025
@vstinner
[3.13] pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465
6a286e6 
) (python#119479)

pythongh-119461: Fix ThreadedVSOCKSocketStreamTest (python#119465)

Fix ThreadedVSOCKSocketStreamTest: if get_cid() returns the host
address or the "any" address, use the local communication address
(loopback): VMADDR_CID_LOCAL.

On Linux 6.9, apparently, the /dev/vsock device is now available but
get_cid() returns VMADDR_CID_ANY (-1).

(cherry picked from commit e94dbe4)
(cherry picked from commit c750061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @bedevere-bot