bpo-39799: Never return base's fragment from urllib.parse.urljoin #18710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC3986 5.2.2., target fragment is always reference fragment. https://bugs.python.org/issue39799
Codecov Report
@@ Coverage Diff @@
## master #18710 +/- ##
=========================================
Coverage 82.13% 82.13%
=========================================
Files 1956 1955 -1
Lines 589974 584599 -5375
Branches 44484 44483 -1
=========================================
- Hits 484572 480160 -4412
+ Misses 95750 94791 -959
+ Partials 9652 9648 -4
Continue to review full report at Codecov.
|
epicfaace
suggested changes
Mar 15, 2020
Lib/test/test_urlparse.py
Outdated
| @@ -449,6 +449,9 @@ def test_urljoins(self): | |||
| # issue 23703: don't duplicate filename | |||
| self.checkJoin('a', 'b', 'b') | |||
|
|
|||
| # issue 39799: no base fragment (not compatible with RFC1808) | |||
| self.checkJoin('http://a/b#f', '', 'http://a/b') | |||
There was a problem hiding this comment.
Can you move this test to be under test_RFC3986?
Lib/test/test_urlparse.py
Outdated
| @@ -449,6 +449,9 @@ def test_urljoins(self): | |||
| # issue 23703: don't duplicate filename | |||
| self.checkJoin('a', 'b', 'b') | |||
|
|
|||
| # issue 39799: no base fragment (not compatible with RFC1808) | |||
| self.checkJoin('http://a/b#f', '', 'http://a/b') | |||
There was a problem hiding this comment.
Can you add a test for self.checkJoin('http://a/b/#f', 'g', 'http://a/b/g')?
| @@ -0,0 +1,3 @@ | |||
| Fix ``urllib.parse.urljoin`` | |||
There was a problem hiding this comment.
Can you mention that this is in order to conform with RFC 3986?
|
@epicfaace I edited accordingly. |
epicfaace
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC3986 5.2.2.,
target fragment is always reference fragment.
https://bugs.python.org/issue39799
https://bugs.python.org/issue39799