Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39114: Fix handling of line numbers around finally-blocks. #17737

Merged

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 29, 2019

Restores the line number after emitting the code for a finally block.

https://bugs.python.org/issue39114

@pablogsal
Copy link
Member

pablogsal commented Dec 29, 2019

You need to regenerate the frozen importlib and other frozen stuff, no? (make regen-all to make sure).

@markshannon markshannon force-pushed the fix-linenumbers-around-finallly-blocks branch from f3b9fbe to f254546 Compare Dec 29, 2019
@pablogsal pablogsal self-requested a review Dec 29, 2019
Copy link
Member

@pablogsal pablogsal left a comment

Looks good to me. Thanks for the fix!

@markshannon markshannon merged commit 88dce26 into python:master Dec 30, 2019
@markshannon markshannon deleted the fix-linenumbers-around-finallly-blocks branch Dec 30, 2019
@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2019

@markshannon: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants