Skip to content

bpo-38388 Document pickle protocol version 5 #16639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2019
Merged

bpo-38388 Document pickle protocol version 5 #16639

merged 2 commits into from
Nov 3, 2019

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Oct 8, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 8, 2019
@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 8, 2019

Can someone add skip news and type-documentation labels on this PR?

P.S. I'm not sure how to request this PR to be backported to 3.8 branch.

@tirkarthi
Copy link
Member

The backport PR will be done as backport label is added by core dev/triager and this PR is merged to master.

taleinat
taleinat requested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the paragraph preceding the list of protocols, the line "There are currently 5 different protocols..." needs to be updated as well.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 12, 2019

In the paragraph preceding the list of protocols, the line "There are currently 5 different protocols..." needs to be updated as well.

Done, thanks!

tirkarthi
tirkarthi approved these changes Nov 3, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you need to add "I have made the requested changes; please review again." as a comment for the bot to change labels and request a review. Thanks.

@taleinat taleinat merged commit d0e0f5b into python:master Nov 3, 2019
@miss-islington
Copy link
Contributor

Thanks @dimaqq for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17035 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2019
@dimaqq @miss-islington
bpo-38388: Document pickle protocol version 5 (pythonGH-16639)
d109228 
(cherry picked from commit d0e0f5b)

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
miss-islington added a commit that referenced this pull request Nov 3, 2019
@miss-islington @dimaqq
bpo-38388: Document pickle protocol version 5 (GH-16639)
87af518 
(cherry picked from commit d0e0f5b)

Co-authored-by: Dima Tisnek <dimaqq@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@dimaqq
bpo-38388: Document pickle protocol version 5 (pythonGH-16639)
75cdfea
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@dimaqq @shihai1991
bpo-38388: Document pickle protocol version 5 (pythonGH-16639)
80a3fe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimaqq @tirkarthi @bedevere-bot @miss-islington @taleinat @the-knights-who-say-ni