[3.9] bpo-39349: Add cancel_futures to Executor.shutdown base class (GH-22023) #22048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-22023) * Add cancel_futures parameter to the Executor base class, since it was missed in the original PR (python#18057) that added cancel_futures. (cherry picked from commit 17dc1b7) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
aeros
approved these changes
Sep 1, 2020
|
Looks all green here! Thanks for the speedy reviews! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 17dc1b7)
Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com
https://bugs.python.org/issue39349