New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-17005: Add a topological sort algorithm #11583
Conversation
9048fbb
to
bc0512c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if API design should happen here or back on the issue, but I'll start with here.
@rhettinger Could you advise about the API of this function? I think the new API is more convenient but a bit less powerful, but I am waiting for your input on this matter to continue development/discussion :) |
Just to make it simpler to evaluate. The equivalent input for:
would be:
and the result is:
representing that you can choose an arbitrary order in every group and that satisfies the sorting. |
Co-Authored-By: Tim Peters <tim.peters@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling, mechanics, and clarity in docs.
Co-Authored-By: sweeneyde <36520290+sweeneyde@users.noreply.github.com>
@tim-one @larryhastings The PR has been still for a while and I think is close to being ready for a first merge. I would like to get this in before the 3rd alpha so there is plenty of time to test this and still have possibilities to change things. Do you have any changes to the API that you would like to be changed? What about Larry's paint cans? 😆 Improvement to the docs can be made later as this can always be modified freely after the feature freeze :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 😃 I added one note, suggesting that CycleError
be documented, and listing the salient points to cover.
Now that the Thank you very much to everyone involved in this issue, the discussions and for all the patience with reviews and iterations (thanks to @tim-one especially 👌 ). |
… library (pythonGH-11583) Co-Authored-By: Tim Peters <tim.peters@gmail.com>
@@ -166,6 +166,13 @@ ftplib | |||
if the given timeout for their constructor is zero to prevent the creation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablogsal the file Doc/myfile.bz2 above does not seem referenced from anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That has been corrected since this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://bugs.python.org/issue17005