[Mailer] Use recipients in sendmail transport #45690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @l-vo has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
HypeMC
force-pushed
the
sendmail-recipients-fix
branch
2 times, most recently
from
bd7c8e6
to
4f3a89a
Compare
fabpot
approved these changes
Mar 18, 2022
| @@ -86,6 +86,11 @@ protected function doSend(SentMessage $message): void | |||
| $this->getLogger()->debug(sprintf('Email transport "%s" starting', __CLASS__)); | |||
|
|
|||
| $command = $this->command; | |||
|
|
|||
| if (!empty($recipients = $message->getEnvelope()->getRecipients())) { | |||
There was a problem hiding this comment.
Suggested change
| if (!empty($recipients = $message->getEnvelope()->getRecipients())) { | |
| if ($recipients = $message->getEnvelope()->getRecipients()) { |
|
Thank you @HypeMC. |
This was referenced Apr 2, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Supersedes #41150