[Security] Fixed TOCTOU in RememberMe cache token verifier #45808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zerkms
commented
Mar 22, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #42637 |
| License | MIT |
| Doc PR |
carsonbot
changed the title
zerkms
force-pushed
the
I42637-toctou-cachetokenverifier
branch
from
a84f9ee
to
2b8bee5
Compare
|
UPD: failed tests are unrelated to the changed code |
nicolas-grekas
reviewed
Mar 22, 2022
src/Symfony/Component/Security/Core/Authentication/RememberMe/CacheTokenVerifier.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
zerkms
force-pushed
the
I42637-toctou-cachetokenverifier
branch
from
2b8bee5
to
409897b
Compare
fabpot
approved these changes
Mar 24, 2022
|
Thank you @zerkms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.