Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] get_gmtoff() now returns time_t (GH-10838) #10839

Merged
merged 1 commit into from Dec 1, 2018
Merged

[3.7] get_gmtoff() now returns time_t (GH-10838) #10839

merged 1 commit into from Dec 1, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 30, 2018

get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

Modules\timemodule.c(1183): warning C4244: 'return':
conversion from 'time_t' to 'int', possible loss of data

(cherry picked from commit 503ce5c)

@vstinner
get_gmtoff() now returns time_t (GH-10838)
7651500 
get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

    Modules\timemodule.c(1183): warning C4244: 'return':
    conversion from 'time_t' to 'int', possible loss of data

(cherry picked from commit 503ce5c)
@bedevere-bot bedevere-bot mentioned this pull request Nov 30, 2018
Merged
@vstinner vstinner merged commit 38c06d9 into python:3.7 Dec 1, 2018
@vstinner vstinner deleted the get_gmtoff_time_t37 branch Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot