Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: fix typo in test doc, fix flake8 issues #17856

Merged
merged 2 commits into from Jan 9, 2020
Merged

minor: fix typo in test doc, fix flake8 issues #17856

merged 2 commits into from Jan 9, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 6, 2020

No description provided.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 6, 2020
@tirkarthi
Copy link
Member

tirkarthi commented Jan 6, 2020

Typo fix LGTM. I am not sure the whitespace changes are needed. There are other parts in stdlib that are also not flake8 compliant.

@blueyed
Copy link
Contributor Author

blueyed commented Jan 6, 2020

ok, reverted - I've just thought it could be also fixed while at it.

tirkarthi
tirkarthi approved these changes Jan 6, 2020
View changes
Copy link
Member

@tirkarthi tirkarthi left a comment

LGTM. Thanks.

@tirkarthi tirkarthi merged commit 2f65aa4 into python:master Jan 9, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jan 9, 2020

Thanks @blueyed for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2020
@blueyed @miss-islington
Fix typo in test's docstring (pythonGH-17856)
1a57b21 
* Fix typo in test's docstring. contination -> continuation.
(cherry picked from commit 2f65aa4)

Co-authored-by: Daniel Hahler <git@thequod.de>
@bedevere-bot
Copy link

bedevere-bot commented Jan 9, 2020

GH-17923 is a backport of this pull request to the 3.8 branch.

@tirkarthi
Copy link
Member

tirkarthi commented Jan 9, 2020

Thanks @blueyed :)

tirkarthi pushed a commit that referenced this pull request Jan 9, 2020
@miss-islington @blueyed @tirkarthi
Fix typo in test's docstring (GH-17856) (GH-17923)
e47a7e3 
* Fix typo in test's docstring. contination -> continuation.
(cherry picked from commit 2f65aa4)

Co-authored-by: Daniel Hahler <git@thequod.de>

Co-authored-by: Daniel Hahler <github@thequod.de>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@blueyed @shihai1991
Fix typo in test's docstring (pythonGH-17856)
106d785 
* Fix typo in test's docstring. contination -> continuation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi

Assignees
No one assigned
Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blueyed @tirkarthi @miss-islington @bedevere-bot @the-knights-who-say-ni