symfony / symfony

piwifr wants someone to pull 1 commit into symfony:master from piwifr:master

Showing 1 comment with 1 commit and 0 commit comments

#21 Closed

Fixes 2 errors in displaying a form

piwifr — Thu Oct 14 03:23:15 -0700 2010

Hello,

This commit fixes 2 errors when displaying a form.

Warning error : Missing argument 1 for Symfony\Bundle\FrameworkBundle\Templating\Form\Field::label()
Error fatal :
Call to undefined method
Symfony\Bundle\FrameworkBundle\Templating\Form\Field::getDisplayedData() in file Symfony/Bundle/FrameworkBundle/Resources/views/Form/widget/textarea_field.php

piwifr added some commits

Thu Oct 14 03:00:47 -0700 2010

10ff7bd Fixes a fatal error in file Symfony/Bundle/FrameworkBundle/Resources/...

fabpot commented

Fri Oct 15 09:31:32 -0700 2010

the label() method has already been fixed in my repo (fabpot/symfony).
The other one I'm not sure about as the 'field' attribute must be the value of '$this'. To access the original field, we must use '$origin'. So, the fix should be in the template. I will commit the fix in my repo in a minute.

Comment on this pull request

You must be logged in to comment on pull requests.

Showing 1 unique commit by 1 author.

10ff7bdd piwifr Fixes a fatal error in file Symfony/Bundle/FrameworkBundle/Resour... Thu Oct 14 03:00:47 -0700 2010

Showing 1 changed files with 2 additions and 2 deletions.

src/Symfony/Bundle/FrameworkBundle/Templating/Form/Field.php

4 ••••

src/Symfony/Bundle/FrameworkBundle/Templating/Form/Field.php

View file @ 10ff7bd

          
                  @@ -49,14 +49,14 @@ class Field extends BaseField

                           }

                           return $this->engine->render($template, array(

                  -            'field'      => $this,

                  +            'field'      => $this->field,

                               'origin'     => $this->field,

                               'attributes' => array_merge($this->field->getAttributes(), $attributes),

                               'generator'  => $this->generator,

                           ));

                       }

                  -    public function label($label, $template = null)

                  +    public function label($label = false, $template = null)

                       {

                           if (null === $template) {

                               $template = 'FrameworkBundle:Form:label.php';

...	...	@@ -49,14 +49,14 @@ class Field extends BaseField
49	49	}
50	50
51	51	return $this->engine->render($template, array(
52		- 'field' => $this,
	52	+ 'field' => $this->field,
53	53	'origin' => $this->field,
54	54	'attributes' => array_merge($this->field->getAttributes(), $attributes),
55	55	'generator' => $this->generator,
56	56	));
57	57	}
58	58
59		- public function label($label, $template = null)
	59	+ public function label($label = false, $template = null)
60	60	{
61	61	if (null === $template) {
62	62	$template = 'FrameworkBundle:Form:label.php';

symfony / symfony

Fixes 2 errors in displaying a form

Comment on this pull request

Active Participants

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph