symfony / symfony

brtriver wants someone to pull 1 commit into symfony:master from brtriver:bugfix-webprofiler

Showing 0 comments with 1 commit and 0 commit comments

#15 Closed

Bugfix webprofiler

brtriver — Fri Oct 08 05:14:42 -0700 2010

I caught an error in WebProfiler page like below.

Fatal error: Call to a member function getRawValue() on a non-object in /path-to-sandbox/src/vendor/symfony/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/request_panel.php on line 45

When the session attributes don't exist, $data->sessionAttributes->getRawValue() cannot be called as not being defined.
So I added the check whether the session attributes exist or not before calling getRawValue().

brtriver added some commits

Fri Oct 08 05:02:02 -0700 2010

105cf68 fixed: fixed the bug of request_panel.php in WebProfiler

Comment on this pull request

You must be logged in to comment on pull requests.

Showing 1 unique commit by 1 author.

105cf682 brtriver fixed: fixed the bug of request_panel.php in WebProfiler Fri Oct 08 05:02:02 -0700 2010

Showing 1 changed files with 3 additions and 1 deletion.

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/request_panel.php

4 ••••

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/request_panel.php

View file @ 4027f75

@@ -42,7 +42,8 @@
         <th>Value</th>
     </tr>
 
-    <?php foreach ($data->getSessionAttributes()->getRawValue() as $key => $value): ?>
+    <?php if (count($sessionAttributes = $data->getSessionAttributes())):?>
+    <?php foreach ($sessionAttributes->getRawValue() as $key => $value): ?>
         <tr>
             <th><?php echo $key ?></th>
             <td>
@@ -58,4 +59,5 @@
             </td>
         </tr>
     <?php endforeach; ?>
+    <?php endif; ?>
 </table>

symfony / symfony

Bugfix webprofiler

Comment on this pull request

Active Participants

Your current locale selection: English. Choose another?

Keyboard Shortcuts

Site wide shortcuts

Commit list

Pull request list

Issues

Network Graph

...	...	@@ -42,7 +42,8 @@
42	42	<th>Value</th>
43	43	</tr>
44	44
45		- <?php foreach ($data->getSessionAttributes()->getRawValue() as $key => $value): ?>
	45	+ <?php if (count($sessionAttributes = $data->getSessionAttributes())):?>
	46	+ <?php foreach ($sessionAttributes->getRawValue() as $key => $value): ?>
46	47	<tr>
47	48	<th><?php echo $key ?></th>
48	49	<td>
...	...	@@ -58,4 +59,5 @@
58	59	</td>
59	60	</tr>
60	61	<?php endforeach; ?>
	62	+ <?php endif; ?>
61	63	</table>