Skip to content

bpo-35513: Replace time.time() with time.monotonic() in tests #11182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

bpo-35513: Replace time.time() with time.monotonic() in tests #11182

merged 1 commit into from
Dec 17, 2018

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 16, 2018 •
edited by bedevere-bot
Loading

Replace time.time() with time.monotonic() in tests to measure time
delta.

https://bugs.python.org/issue35513

@vstinner
bpo-35513: Replace time.time() with time.monotonic() in tests
59e03bb 
Replace time.time() with time.monotonic() in tests to measure time
delta.
@vstinner
Copy link
Member Author

Note: the PR also changes test_zipfile64 to display progress every minute (60 secs) rather than every 5 minutes (5*60 seconds).

asvetlov
asvetlov approved these changes Dec 16, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner vstinner merged commit 2cf4c20 into python:master Dec 17, 2018
@vstinner vstinner deleted the time_monotonic branch December 17, 2018 08:36
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11185 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2018
@vstinner @miss-islington
bpo-35513: Replace time.time() with time.monotonic() in tests (python…
b255cb3 
…GH-11182)

Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Dec 17, 2018
@miss-islington @vstinner
bpo-35513: Replace time.time() with time.monotonic() in tests (GH-11182)
be69ff2 
Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni