Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.7] bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() (GH-9760) #9957

Merged
merged 1 commit into from Oct 19, 2018
Merged

[3.7] bpo-34936: Fix TclError in tkinter.Spinbox.selection_element() (GH-9760) #9957

merged 1 commit into from Oct 19, 2018

Conversation

j4321
Copy link
Contributor

@j4321 j4321 commented Oct 18, 2018 •
edited by serhiy-storchaka

I removed the tests for the unimplemented methods in 3.7.

(cherry picked from commit 1deea5e)

https://bugs.python.org/issue34936

@bedevere-bot bedevere-bot mentioned this pull request Oct 18, 2018
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Oct 18, 2018
@serhiy-storchaka serhiy-storchaka merged commit bd9c2ce into python:3.7 Oct 19, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @j4321 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @j4321 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2018

Thanks @j4321 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2018
@j4321 @miss-islington
bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (pyth…
801f733 
…onGH-9760) (pythonGH-9957)

(cherry picked from commit 1deea5e)
(cherry picked from commit bd9c2ce)

Co-authored-by: Juliette Monsel <j4321@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2018

GH-9967 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2018

Sorry, @j4321 and @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bd9c2ce7acaef45f23c2659b854fc9925096d040 3.7

@miss-islington
Copy link
Contributor

miss-islington commented Oct 19, 2018

Sorry, @j4321 and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker bd9c2ce7acaef45f23c2659b854fc9925096d040 2.7

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Oct 19, 2018

Thank you @j4321. For future, you can use the cherry_picker utility for convenience. It can perform some routine actions for you.

miss-islington added a commit that referenced this pull request Oct 19, 2018
@miss-islington @j4321
bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (GH-9760
c04347f 
) (GH-9957)

(cherry picked from commit 1deea5e)
(cherry picked from commit bd9c2ce)

Co-authored-by: Juliette Monsel <j4321@users.noreply.github.com>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 19, 2018
@j4321 @serhiy-storchaka
[2.7] bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (…
ceb2250 
…pythonGH-9760) (pythonGH-9957)

(cherry picked from commit 1deea5e).
(cherry picked from commit bd9c2ce)

Co-authored-by: Juliette Monsel <j4321@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 19, 2018

GH-9968 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 21, 2018
@serhiy-storchaka @j4321
[2.7] bpo-34936: Fix TclError in tkinter.Spinbox.selection_element(). (…
427b8c7 
…GH-9760) (GH-9957) (GH-9968)

(cherry picked from commit 1deea5e).
(cherry picked from commit bd9c2ce)

Co-authored-by: Juliette Monsel <j4321@users.noreply.github.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@j4321 @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni