Skip to content

[3.7] bpo-35310: Clear select() lists before returning upon EINTR (GH-10877) #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 5, 2018

select() calls are retried on EINTR (per PEP 475). However, if a
timeout was provided and the deadline has passed after running the
signal handlers, rlist, wlist and xlist should be cleared since select(2)
left them unmodified.
(cherry picked from commit 7f52415)

Co-authored-by: Oran Avraham 252748+oranav@users.noreply.github.com

https://bugs.python.org/issue35310

…-10877)

select() calls are retried on EINTR (per PEP 475).  However, if a
timeout was provided and the deadline has passed after running the
signal handlers, rlist, wlist and xlist should be cleared since select(2)
left them unmodified.
(cherry picked from commit 7f52415)

Co-authored-by: Oran Avraham <252748+oranav@users.noreply.github.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@oranav and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 3451078 into python:3.7 Dec 5, 2018
@miss-islington miss-islington deleted the backport-7f52415-3.7 branch December 5, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants