Fix: Do not use numeric tolerances for axline special cases #28987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertical lines (infinite slope) and two identical points as input need special handling in AxLine. The detection was using numeric tolerances, which lead to false-positive detection in cases that are close to but not exactly those special cases. This PR removes the tolerances. The argument is the same as for the similar case matplotlib#28386 (comment) Closes matplotlib#28870.
scottshambaugh
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
This closes out the last of the comparisons called out in this comment, lgtm! #28386 (comment)
|
This might be better considered as a bugfix for the 3.9.3 milestone. |
ksunden
approved these changes
Oct 17, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 17, 2024
…axline special cases
QuLogic
added a commit
that referenced
this pull request
Oct 18, 2024
…987-on-v3.9.x Backport PR #28987 on branch v3.9.x (Fix: Do not use numeric tolerances for axline special cases)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vertical lines (infinite slope) and two identical points as input need special handling in AxLine. The detection was using numeric tolerances, which lead to false-positive detection in cases that are close to but not exactly those special cases.
This PR removes the tolerances. The argument is the same as for the similar case #28386 (comment)
Closes #28870.