Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on library/ssl.po #829

Merged
merged 12 commits into from Apr 1, 2020
Merged

working on library/ssl.po #829

merged 12 commits into from Apr 1, 2020

Conversation

@svngoku
Copy link
Contributor

svngoku commented Jun 20, 2019

No description provided.

Copy link
Collaborator

christopheNan left a comment

Merci pour cette bonne contribution.
Je te conseille de lire les règles typographiques liées à la ponctuation et de refaire une passe. Il y a des espaces avant les ponctuations.

library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
@svngoku
Copy link
Contributor Author

svngoku commented Jun 24, 2019

Merci pour le super retour . 👍

@christopheNan
Copy link
Collaborator

christopheNan commented Jun 24, 2019

Merci d'avoir pris en compte les remarques.
Maintenant, tu peux examiner le retour de Travis qui t'indique quelques erreurs :
clique ci-dessous sur le lien "Détails" à droite de "continuous-integration/travis-ci/pr" et regarde les lignes :

  • 269 : powrap conclut que les fichiers sont correctement alignés (ils ne dépassent pas 80 colonnes)
  • 271 à 290 : pospell indique qu'il y a plusieurs mots non reconnus et des erreurs de formatage RST.
@JulienPalard
Copy link
Member

JulienPalard commented Aug 14, 2019

ping @svngoku

@svngoku
Copy link
Contributor Author

svngoku commented Aug 15, 2019

1 packets transmitted, 1 received, 0% packet loss, time 11015ms 👍

@svngoku
Copy link
Contributor Author

svngoku commented Aug 15, 2019

Bonsoir @christopheNan , j'ai une petite question concernant l'expressions cipher string .
Comment pourrais-je la définir ?

Merci bien 👍

@christopheNan
Copy link
Collaborator

christopheNan commented Aug 15, 2019

@svngoku
Copy link
Contributor Author

svngoku commented Aug 16, 2019

@christopheNan Merci beaucoup pour le retour .

@Seluj78
Copy link
Collaborator

Seluj78 commented Oct 9, 2019

@svngoku Hello, petit ping ? 🏓

library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
@svngoku
Copy link
Contributor Author

svngoku commented Oct 16, 2019

Merciii pour le retour @JulienPalard

@Seluj78
Copy link
Collaborator

Seluj78 commented Nov 15, 2019

Hello @svngoku ! Il suffit maintenant que tu accepte les suggestions (https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request) et que tu résoude le pb de la CI ! :D

@Seluj78 Seluj78 added this to In progress in Traduction via automation Nov 15, 2019
@Seluj78 Seluj78 changed the title working on ssl working on library/ssl.po Nov 17, 2019
@Seluj78 Seluj78 requested a review from christopheNan Dec 11, 2019
@JulienPalard JulienPalard force-pushed the svngoku:ssl branch from 33c18db to 5d0a35f Feb 1, 2020
@JulienPalard JulienPalard changed the base branch from 3.7 to 3.8 Feb 1, 2020
@JulienPalard
Copy link
Member

JulienPalard commented Feb 1, 2020

J'ai rebasé cette PR sur la 3.8.

Traduction automation moved this from In progress to Done Feb 1, 2020
@JulienPalard JulienPalard reopened this Feb 1, 2020
Traduction automation moved this from Done to In progress Feb 1, 2020
@deronnax deronnax self-assigned this Mar 29, 2020
deronnax added 3 commits Mar 30, 2020
@deronnax deronnax closed this Mar 30, 2020
Traduction automation moved this from Review in progress to Done Mar 30, 2020
@deronnax deronnax reopened this Mar 30, 2020
Traduction automation moved this from Done to In progress Mar 30, 2020
Copy link
Collaborator

christopheNan left a comment

Quelques petits points, dont un que je remonte upstream.

library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
library/ssl.po Outdated Show resolved Hide resolved
Traduction automation moved this from In progress to Review in progress Mar 31, 2020
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@deronnax deronnax dismissed stale reviews from christopheNan and christopheNan via e660e86 Apr 1, 2020
@deronnax
Copy link
Collaborator

deronnax commented Apr 1, 2020

Alors j'ai traduit "totaly broken" par "totalement defectueux", mais je pense qu'en fait "totalement deficient" serait plus juste : https://www.larousse.fr/dictionnaires/francais/d%C3%A9ficient/22671

@christopheNan ?

@christopheNan
Copy link
Collaborator

christopheNan commented Apr 1, 2020

@deronnax
Copy link
Collaborator

deronnax commented Apr 1, 2020

des fois je te laisse des questions en commentaire, qui ne sont pas des suggestions de code, mais tu n'y répond jamais (lors que ça n'est pas des suggestions de code) 😢
Capture d’écran 2020-04-01 à 20 33 10

@deronnax deronnax force-pushed the svngoku:ssl branch from 84811ef to a2f1c6c Apr 1, 2020
@deronnax deronnax dismissed JulienPalard’s stale review Apr 1, 2020

tous les points ont été traités + Julien pas dispo ATM

Traduction automation moved this from Review in progress to Reviewer approved Apr 1, 2020
@deronnax deronnax merged commit e51ec9a into python:3.8 Apr 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Traduction automation moved this from Reviewer approved to Done Apr 1, 2020
@deronnax
Copy link
Collaborator

deronnax commented Apr 1, 2020

Hop c'est fusionné. Merci @svngoku ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Traduction
  
Done
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.