Add unix domain socket based async channel test #3225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Apr 28, 2025
danieleggert
force-pushed
the
add-unix-domain-socket-test
branch
from
d2a74da to
6771f4e
Compare
glbrntt
reviewed
May 1, 2025
| group.addTask { | ||
| // Create a client connection to the server: | ||
| let clientChannel = try await makeClientChannel(path: path) | ||
| print("Executing client channel") |
There was a problem hiding this comment.
Even in test code? This is super helpful for diagnosing these when they fail.
| } | ||
| print("S: Bye") | ||
| } | ||
| } catch { |
There was a problem hiding this comment.
Can we just make handleConnection throwing and propagate that error up rather than suppressing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unix domain socket based async channel test.
Motivation:
This adds additional test coverage, and also provides an example for how to setup async-channel based UNIX domain socket channel pairs (server + client).
Modifications:
Adds a new file with test code.
Result:
Changes to test only.