Skip to content

DARS-17468 control: Prevent start if transparent hugepages are enabled #16313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DARS-17468 control: Prevent start if transparent hugepages are enabled #16313

wants to merge 4 commits into from

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Apr 25, 2025 •
edited
Loading

When THP feature is enabled on linux platforms, SPDK related
hugepage management in DAOS performs sub-optimally. Resulting problems
relate to memory accounting and fragmentation. To remedy, refuse to
start daos_server if THP is enabled on platform and recommend
disabling THP by applying kernel commandline parameters effective on
reboot.

Features: control

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@tanabarr tanabarr requested review from a team as code owners April 25, 2025 11:45
@github-actions GitHub Actions
Copy link

Errors are Ticket number prefix incorrect,Unable to load ticket data
https://daosio.atlassian.net/browse/DARS-17468

@tanabarr tanabarr self-assigned this Apr 25, 2025
@tanabarr
DAOS-17468 control: Prevent start if transparent hugepages are enabled
5c07867 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr force-pushed the tanabarr/control-no-thp branch from d46e506 to 5c07867 Compare April 25, 2025 15:16
@tanabarr tanabarr requested a review from a team as a code owner April 25, 2025 15:16
@tanabarr
change implementation to query sysfs file
a8b8809 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
kjacque
kjacque requested changes Apr 28, 2025
View reviewed changes
@tanabarr
address review comments
95f3af4 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
@tanabarr tanabarr requested review from kjacque, mjmac and knard38 April 29, 2025 22:12
@tanabarr
remove inadvertent change
b4f9a25 
Features: control
Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
kjacque
kjacque approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my issues were addressed. You'll want to fix the typo in the title of the PR (DARS -> DAOS), otherwise looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacque kjacque kjacque approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees

@tanabarr tanabarr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanabarr @kjacque @knard38