Clarify accepted values for kms_key_id in aws_cloudwatch_log_group documentation (#41606) #42402
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
needs-triage
| @@ -34,8 +34,10 @@ This resource supports the following arguments: | |||
| * `retention_in_days` - (Optional) Specifies the number of days | |||
| you want to retain log events in the specified log group. Possible values are: 1, 3, 5, 7, 14, 30, 60, 90, 120, 150, 180, 365, 400, 545, 731, 1096, 1827, 2192, 2557, 2922, 3288, 3653, and 0. | |||
| If you select 0, the events in the log group are always retained and never expire. | |||
| * `kms_key_id` - (Optional) The ARN of the KMS Key to use when encrypting log data. Please note, after the AWS KMS CMK is disassociated from the log group, | |||
| AWS CloudWatch Logs stops encrypting newly ingested data for the log group. All previously ingested data remains encrypted, and AWS CloudWatch Logs requires | |||
| * `kms_key_id` - (Optional) The Amazon Resource Name (ARN), Key ID, or alias ARN of the AWS KMS Key to use when encrypting log data. | |||
There was a problem hiding this comment.
This resources uses CreateLogGroup, for which the documentation seems to indicate that an ARN is required, and the linked issue seems to indicate that the key ID isn't an accepted value.
Do you have a reference that indicated that the key ID (or Alias ARN, though that very well could be accepted) should be accepted here?
justinretzolk
added
the
waiting-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the documentation for the
kms_key_idattribute of theaws_cloudwatch_log_groupresource.Changes:
kms_key_idfield accepts a Key ID, full ARN, or alias ARN.This clarification aligns the documentation with AWS's accepted input formats for KMS keys in CloudWatch Logs.
Fixes #41606