Skip to content

fix: ineffectual assignment #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ineffectual assignment #2419

wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Collaborator

Description

Fix ineffectual assignment.

Before:

~/Downloads/terraform-provider-vsphere git:[fix/ineffectual-assignment]
golangci-lint run
vsphere/resource_vsphere_compute_cluster.go:1762:5: ineffectual assignment to hostIds (ineffassign)
                                hostIds = append(hostIds.([]string), vsanHost.HostSystem.Value)
                                ^
vsphere/resource_vsphere_virtual_machine.go:1657:2: ineffectual assignment to devices (ineffassign)
        devices, delta, err = virtualdevice.NormalizeBus(devices, d)
        ^

2 issues:
* ineffassign: 2

After:

~/Downloads/terraform-provider-vsphere git:[fix/ineffectual-assignment]
golangci-lint run
0 issues.

@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from spacegospod April 26, 2025 04:37
@tenthirtyam tenthirtyam self-assigned this Apr 26, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 26, 2025 04:37
@tenthirtyam tenthirtyam added this to the v2.13.0 milestone Apr 26, 2025
@tenthirtyam tenthirtyam added the needs-review Needs Review label Apr 26, 2025
@tenthirtyam tenthirtyam marked this pull request as draft April 29, 2025 12:01
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Apr 29, 2025
@tenthirtyam tenthirtyam force-pushed the fix/ineffectual-assignment branch from 12695ac to 2492f28 Compare April 29, 2025 23:23
@tenthirtyam tenthirtyam changed the title fix: ineffectual assignment [wip] fix: ineffectual assignment Apr 29, 2025
@tenthirtyam tenthirtyam force-pushed the fix/ineffectual-assignment branch 5 times, most recently from 626bd5c to 1e657fd Compare May 2, 2025 21:34
@tenthirtyam
fix: ineffectual assignment
12e5224 
Fix ineffectual assignment.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the fix/ineffectual-assignment branch from 1e657fd to 12e5224 Compare May 2, 2025 21:34
@tenthirtyam tenthirtyam marked this pull request as ready for review May 2, 2025 21:34
@tenthirtyam tenthirtyam requested a review from iBrandyJackson May 2, 2025 21:35
@tenthirtyam tenthirtyam changed the title [wip] fix: ineffectual assignment fix: ineffectual assignment May 2, 2025
@tenthirtyam tenthirtyam requested a review from spacegospod May 2, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBrandyJackson iBrandyJackson Awaiting requested review from iBrandyJackson

@spacegospod spacegospod Awaiting requested review from spacegospod

At least 1 approving review is required to merge this pull request.

Assignees

@tenthirtyam tenthirtyam

Labels
refactor Refactor technical-debt Technical Debt
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tenthirtyam @spacegospod