[wip] refactor: sdrs disk placement for multi-disk vms #2457
+33
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
force-pushed
the
refactor/storagepod-disk-placement
branch
from
fcc0b24 to
2bb0f56
Compare
- Modifoes `expandVMPodConfigForPlacement` to generate a single `VmPodConfigForPlacement` structure containing `PodDiskLocator` entries for all disks associated with the VM. This sends a cohesive placement request to Storage DRS. - Modifies `applySDRS` to collect all recommendation keys from the `StoragePlacementResult` and pass them to the `ApplyStorageDrsRecommendation` API call. This ensures all parts of the placement recommendation are executed. Ref: #2448 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
refactor/storagepod-disk-placement
branch
from
2bb0f56 to
1a97e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
TESTING IS PENDING
expandVMPodConfigForPlacementto generate a singleVmPodConfigForPlacementstructure containingPodDiskLocatorentries for all disks associated with the VM. This sends a cohesive placement request to Storage DRS.applySDRSto collect all recommendation keys from theStoragePlacementResultand pass them to theApplyStorageDrsRecommendationAPI call. This ensures all parts of the placement recommendation are executed.Reference
Closes #2448