playground: add beforeunload event listener to prevent data loss #12961
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a beforeunload event listener to the PlaygroundViewModel to prevent data loss when navigating away from the page. The listener is added when the preanalyse method is called and removed after the analysis is shared. See: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#examples
|
Hi, I imagined we should back up and restore the unsaved code with the localStorage API. |
|
I looked into that as well and we can do both, but this was easiest path to not accidentally lose unsaved changes. Of course, this does not cover scenarios like a browser crash but that's more rare in my opinion than accidentally clicking the back button / closing the tab. With the local storage option there's other things to consider like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Related to: #12956
This adds a beforeunload event listener to the PlaygroundViewModel to prevent data loss when navigating away from the page. The listener is added when the preanalyse method is called and removed after the analysis is shared.
See: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#examples
Thanks!