fix: lockfile not frozen when prefer-frozen-lockfile is set to true in .npmrc #9072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
fa93hws
commented
Feb 10, 2025
| @@ -12,7 +12,8 @@ | |||
| "removeComments": false, | |||
| "sourceMap": true, | |||
| "strict": true, | |||
| "target": "es2021" | |||
| "target": "es2021", | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
No idea why it kept complaining jest error 🤷 . I can't push to remote without it, feel free to remove before merging.
../../../../node_modules/.pnpm/@types+mocha@2.2.48/node_modules/@types/mocha/index.d.ts:66:18 - error TS2300: Duplicate identifier 'afterEach'.
66 declare function afterEach(description: string, callback: (this: Mocha.IBeforeAndAfterContext, done: MochaDone) => any): void;
fa93hws
commented
Feb 10, 2025
Comment on lines
+337
to
+338
| opts.rawLocalConfig['frozen-lockfile'] !== false && | ||
| opts.rawLocalConfig['prefer-frozen-lockfile'] !== false |
There was a problem hiding this comment.
when prefer-frozen-lockfile is set to anything other than true or false, it will be treated as the default value which is true.
default value for frozen-lockfile is true on CI as well. Otherwise it will return false anyway.
|
TBH, I am a bit afraid of these changes as we already had many issues related to this. We might need to do a bigger refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pnpm lock file is outdated
pnpm i --frozen-lockfile->ERR_PNPM_OUTDATED_LOCKFILECI=1 pnpm i --frozen-lockfile->ERR_PNPM_OUTDATED_LOCKFILEHowever, after
echo prefer-frozen-lockfile=true > .npmrcpnpm i --frozen-lockfile->ERR_PNPM_OUTDATED_LOCKFILECI=1 pnpm i --frozen-lockfile-> no errorThis issue can be reproduced in https://github.com/fa93hws/pnpm-freeze-lockfile-reproduce
After checking out
pnpm install --frozen-lockfilefailedCI=1 pnpm installsuccessCI=1 pnpm installfailed aftergit reset --hardand comment outprefer-frozen-lockfile=trueAfter taking a look at the code, it's caused by checking whether the corresponding config is
undefinedor not. So even the value is set totrueexplicitly in.npmrc, it's treated as false when deciding whether to freeze lockfile...