feat(plugin-commands-init): add support for --module flag in pnpm init #9463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add functionality to include "type": "module" in package.json when using --module or -m flag with pnpm init. Updated cliOptionsTypes and handler to handle the new flag and ensure proper sorting of fields in package.json Closes pnpm#9416
|
💖 Thanks for opening this pull request! 💖 |
|
I'd use npm's convention: Reference: npm/init-package-json#313 |
allow users to specify the type field in package.json using the --init-type option. The value can be set to "module" or "commonjs". The option is also integrated with .npmrc, allowing users to define the default value in their configuration file. Invalid values are validated and result in an error. BREAKING CHANGE: replaces the previous --module and -m option with --init-type. Users must now use --init-type to specify the type field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add functionality to include "type": "module" in package.json when using --module or -m flag with pnpm init. Updated cliOptionsTypes and handler to handle the new flag and ensure proper sorting of fields in package.json
Closes #9416