Skip to content

Bundle "Experimental CLI" #17396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Bundle "Experimental CLI" #17396

wants to merge 30 commits into from

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 23, 2025

Description

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@netlify Netlify
Copy link

netlify bot commented Apr 23, 2025 •
edited
Loading

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit 0b12316
🔍 Latest deploy log https://app.netlify.com/sites/prettier/deploys/680af8ecc5a78900083edc21
😎 Deploy Preview https://deploy-preview-17396--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 23, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/prettier@17396

commit: 0b12316

@43081j
Copy link

43081j commented Apr 24, 2025

CI is failing because knip can't see we're importing from experimental-cli

maybe we just need to add those files to the project glob knip uses

@fisker
Copy link
Member Author

fisker commented Apr 24, 2025 •
edited
Loading

I plan to add some simple tests for the new one.

I also need convert the prettier imports into paths I guess.

@fisker fisker force-pushed the bundle-experimental-cli branch 3 times, most recently from 8dd5cc9 to 75fc46a Compare April 24, 2025 12:50
@fisker fisker mentioned this pull request Apr 24, 2025
Merged
@fisker
Copy link
Member Author

fisker commented Apr 24, 2025

@fabiospampinato I've setup tests to test --version, stdin format, file --check and format (both parallel mode and --no-parallel), do you have other cases in mind that should be tested?

@fisker fisker changed the title Bundle "Experimental Cli" Bundle "Experimental CLI" Apr 24, 2025
@fisker fisker mentioned this pull request Apr 24, 2025
Closed
@fisker fisker marked this pull request as ready for review April 24, 2025 17:14
@fisker fisker force-pushed the bundle-experimental-cli branch from d614d0f to 0b12316 Compare April 25, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fisker @43081j