Add user_header tests, minor changes to opencl tests #1084
Conversation
katrinabrock
changed the title
|
@jgabry would you be able to re-trigger the WSL build? It looked like it failed during setup and this PR does have some wsl specific logic so that needs to run for sure before merging. |
|
Just re-triggered it |
|
@katrinabrock just to make sure I'm following, this PR is writing tests to show the current behavior and the next PR will change that behavior? |
|
@SteveBronder Yes, exactly. So then you will also see how the behavior is changing by the diff in the test. |
There was a problem hiding this comment.
I'll wait for @jgabry but imo I think this looks good!
One quick thing. It looks like a lot of your files do not have EOL. Sometimes windows or mac can complain if a file does not have a newline at the end (which is the little red sign you see on github when looking at the file). If you can check your files have a newline at the end that would be great
Submission Checklist
Summary
This PR does two things to prep tests for cpp option logic change:
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Max Planck Institute for Animal Behavior
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: